Skip to content

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Oct 18, 2024

This fixes #1786 which was (mistakenly?) marked as fixed. It's a long-standing issue when using superagent with webpack.

Root Cause: The transitive hexoid dependency exports were invalid and broke webpack.

Related Links:

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Master isn't passing for me locally.

@titanism titanism merged commit 2f8e191 into forwardemail:master Oct 18, 2024
2 checks passed
@titanism
Copy link
Collaborator

v10.1.1 released to npm, thanks for your contributions

https://github.com/ladjs/superagent/releases/tag/v10.1.1

maintenance is sponsored by https://forwardemail.net and many thanks to contributors including yourself @icholy 🙏

@icholy
Copy link
Contributor Author

icholy commented Oct 19, 2024

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] TypeError: hexoid is not a function in Formidable.js when using Webpack + TypeScript

2 participants