Skip to content

Conversation

perrin4869
Copy link
Contributor

Checklist

Follow up to #1805
The reason http2 was failing is that the http2wrapper module was building a url based off of the host, and that needs to be wrapped in square brackets when constructing the string if it is an ipv6. In the case of the http module, it sends a request using the options object, and in that case, the host ip address should not be wrapped in square brackets

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism
Copy link
Collaborator

lmk if this is ready and if you can rebase

@perrin4869 perrin4869 force-pushed the fix/http2/ipv6-addresses branch from 4c4b2d2 to d301224 Compare March 10, 2025 17:12
@perrin4869
Copy link
Contributor Author

done!

@perrin4869 perrin4869 force-pushed the fix/http2/ipv6-addresses branch from d301224 to e29fd25 Compare March 10, 2025 17:21
@titanism titanism merged commit 02cad6a into forwardemail:master Mar 10, 2025
5 checks passed
@titanism
Copy link
Collaborator

https://github.com/ladjs/superagent/releases/tag/v10.2.0 released to npm v10.2.0

thanks many 🙏

our OSS efforts are provided via our service https://forwardemail.net 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants