-
Notifications
You must be signed in to change notification settings - Fork 821
Add Sinhala (Sri Lanka) Locale Support #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jayasanka-sack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have done a great job with the translation @kumuditha-udayanga !
BTW, there are some words required to change. I've marked them with this review.
PS: I'm a native Sinhalese speaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these too..
jayasanka-sack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kumuditha-udayanga
Fix these changes too... (Hopefully last change request 😁)
008ac2e to
1f16be2
Compare
|
All Changes have been done @jayasanka-sack @Piumal1999 could you please review it |
jayasanka-sack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
|
@mariobehling @CloudyPadmal @cweitat It would be nice to have your reviews on this. |
harshamc00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sinhala Translations will indeed be a value-adding feature to the application. As a native Sinhala speaker, I can verify that translations a correct.
CloudyPadmal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Let this PR be an example of how language translation PRs should be evaluated.
Fixes #2033
Changes:
Add Sinhala translation to string.xml.
Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a

*.gifcontaining a demonstration]Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]app-fdroid-debug.apk.zip