Skip to content

Conversation

@kumuditha-udayanga
Copy link
Member

@kumuditha-udayanga kumuditha-udayanga commented Jan 21, 2020

Fixes #2033

Changes:
Add Sinhala translation to string.xml.

Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a *.gif containing a demonstration]
Screenshot 2020-01-21 at 19 13 06

Screenshot 2020-01-21 at 20 48 14

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]

app-fdroid-debug.apk.zip

Copy link

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have done a great job with the translation @kumuditha-udayanga !
BTW, there are some words required to change. I've marked them with this review.

PS: I'm a native Sinhalese speaker.

Copy link

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these too..

Copy link

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumuditha-udayanga
Fix these changes too... (Hopefully last change request 😁)

@fossasia fossasia deleted a comment from kumuditha-udayanga Jan 21, 2020
@kumuditha-udayanga
Copy link
Member Author

All Changes have been done @jayasanka-sack @Piumal1999 could you please review it

Copy link

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@kumuditha-udayanga
Copy link
Member Author

@mariobehling @CloudyPadmal @cweitat It would be nice to have your reviews on this.

Copy link

@harshamc00 harshamc00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinhala Translations will indeed be a value-adding feature to the application. As a native Sinhala speaker, I can verify that translations a correct.

@cweitat cweitat requested a review from CloudyPadmal January 21, 2020 16:00
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let this PR be an example of how language translation PRs should be evaluated.

@CloudyPadmal CloudyPadmal merged commit 41b19e6 into fossasia:development Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sinhala Translation

5 participants