Skip to content

Added CI pipeline using github actions #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CloudyPadmal merged 2 commits into from
Jan 27, 2022
Merged

Added CI pipeline using github actions #2309

CloudyPadmal merged 2 commits into from
Jan 27, 2022

Conversation

@apoorva-raj
Copy link
Contributor

@apoorva-raj apoorva-raj commented Jan 22, 2022

Fixes #2245

Changes:

  • Changed the workflow script to generate new apk in the apk branch after each push to master branch.

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@apoorva-raj
Copy link
Contributor Author

apoorva-raj commented Jan 25, 2022

@CloudyPadmal Have a look at this script

CloudyPadmal
CloudyPadmal requested changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the PR is clean when it’s ready for review

  • One commit
  • Meaningful commit title

CloudyPadmal
CloudyPadmal requested changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into one

CloudyPadmal
CloudyPadmal requested changes Jan 25, 2022
View reviewed changes
@CloudyPadmal
Copy link
Collaborator

CloudyPadmal commented Jan 25, 2022

Again, one single commit, please.

CloudyPadmal
CloudyPadmal requested changes Jan 26, 2022
View reviewed changes
@CloudyPadmal CloudyPadmal merged commit 7c2bff3 into fossasia:development Jan 27, 2022
@apoorva-raj apoorva-raj deleted the new-script branch January 27, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apoorva-raj @CloudyPadmal