-
Notifications
You must be signed in to change notification settings - Fork 825
feat: add automatically generated oss license screen #2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automatically generated oss license screen #2543
Conversation
Reviewer's Guide by SourceryThis pull request adds an automatically generated open-source license screen to the app. It includes changes to the build configuration, adds a new navigation drawer entry, and implements the functionality to display the licenses. The PR also includes a minor UI improvement by replacing a blurry star image in the navigation drawer. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcnause - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Using debug signing config for release builds is a security risk (link)
Overall Comments:
- The change in signing configuration in app/build.gradle.kts (line 47) from a conditional signing to always using the debug signing config for release builds is concerning. This could be a security issue and should be explained or reverted.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/10655349300/artifacts/1879566221 |
Fixes #2498
Changes
Screenshots / Recordings
Screen_recording_20240829_000013.mp4
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard coding any value.strings.xml,dimens.xmlorcolors.xml.Summary by Sourcery
Introduce an automatically generated open source licenses screen accessible from the navigation drawer, and improve the quality of the star image in the navigation drawer. Update the build configuration to include the Google OSS Licenses Plugin.
New Features:
Enhancements:
Build: