Skip to content

Conversation

@marcnause
Copy link
Contributor

@marcnause marcnause commented Aug 28, 2024

Fixes #2498

Changes

  • I replaced the image of the star in the navigation drawer, the old image was a little bit blurry on my device. The new one should look better.
  • I added a new entry called "Open source licenses" to the navigation drawer. It takes the user to an automatically generated overview of 3rd party libraries which are used in the app. Each entry contains a link to the license of the library or the text of the library. (Only release builds contain the list of libraries, debug build will contain a placeholder.)

Screenshots / Recordings

Screen_recording_20240829_000013.mp4

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Introduce an automatically generated open source licenses screen accessible from the navigation drawer, and improve the quality of the star image in the navigation drawer. Update the build configuration to include the Google OSS Licenses Plugin.

New Features:

  • Add a new entry called 'Open source licenses' to the navigation drawer, which directs users to an automatically generated overview of third-party libraries used in the app, including links to their licenses.

Enhancements:

  • Replace the star image in the navigation drawer with a higher quality version to improve visual clarity.

Build:

  • Integrate the Google OSS Licenses Plugin into the project by adding it to the build configuration.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 28, 2024

Reviewer's Guide by Sourcery

This pull request adds an automatically generated open-source license screen to the app. It includes changes to the build configuration, adds a new navigation drawer entry, and implements the functionality to display the licenses. The PR also includes a minor UI improvement by replacing a blurry star image in the navigation drawer.

File-Level Changes

Change Details Files
Added OSS Licenses plugin and dependencies
  • Added com.google.android.gms.oss-licenses-plugin to app/build.gradle.kts
  • Added implementation for com.google.android.gms:play-services-oss-licenses
  • Added classpath for com.google.android.gms:oss-licenses-plugin in build.gradle.kts
app/build.gradle.kts
build.gradle.kts
Implemented new navigation drawer entry for Open Source Licenses
  • Added case for R.id.nav_third_party_libs in onNavigationItemSelected
  • Set activity title and started OssLicensesMenuActivity
app/src/main/java/io/pslab/activity/MainActivity.java
Modified build configuration
  • Changed resConfigs formatting
  • Modified signingConfig for release builds
app/build.gradle.kts
Updated USB permission request
  • Adjusted indentation in attemptToGetUSBPermission method
app/src/main/java/io/pslab/activity/MainActivity.java

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcnause - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Using debug signing config for release builds is a security risk (link)

Overall Comments:

  • The change in signing configuration in app/build.gradle.kts (line 47) from a conditional signing to always using the debug signing config for release builds is concerning. This could be a security issue and should be explained or reverted.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024

@marcnause marcnause merged commit 5d6b449 into fossasia:development Sep 1, 2024
@marcnause marcnause deleted the feat/3rdpartylicenseinfo branch September 1, 2024 15:49
@linsui linsui mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License information missing for dependencies

3 participants