fix: Made search, susi icon invisible in stt fragment #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
reviewed
May 15, 2019
| @@ -326,6 +328,8 @@ class ChatActivity : AppCompatActivity(), IChatView { | |||
| chatPresenter.stopHotwordDetection() | |||
| } | |||
| hideSoftKeyboard(this, window.decorView) | |||
| searchChat.visibility = View.INVISIBLE | |||
| fabsetting.visibility = View.INVISIBLE | |||
There was a problem hiding this comment.
Why not View.GONE, so it will not accessible.
liveHarshit
reviewed
May 15, 2019
| @@ -334,6 +338,8 @@ class ChatActivity : AppCompatActivity(), IChatView { | |||
|
|
|||
| //Replies user with Speech | |||
| override fun voiceReply(reply: String, language: String) { | |||
| searchChat.visibility = View.VISIBLE | |||
| fabsetting.visibility = View.VISIBLE | |||
There was a problem hiding this comment.
And what about it?
When we open up sttfragment, and give some voice commands, the chat activity is not again restarted. It simply calls the function voiceReply. So, it was necessary to make the visibility here
liveHarshit
approved these changes
May 15, 2019
iamareebjamal
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2177
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshots for the change:
