Replace deprecated SASS methods#2100
Conversation
javierjulio
left a comment
javierjulio
left a comment
There was a problem hiding this comment.
@aleho thank you for addressing the deprecations and submitting this. Could you please update the settings file to resolve the other deprecations there?
@joeworkman if this will get updated, would you accept this change and cut a release? It would help to further reduce the Dart Sass deprecations.
*) map-get *) floor, percentage *) lighten, darken, scale-color
|
@javierjulio Is there anything else to do on this PR? |
|
@aleho no, not that I know of. Sorry, I'm not a maintainer. This depends on @joeworkman approving and merging. There is another set of PRs for foundation-sites to resolve SASS deprecations that are all ready for review. |
|
@javierjulio Sorry, my bad! I assumed because you reviewed it you'd be able to merge. Thank you anyway! |
|
Is there any chance that it will be merged? |
4 participants
Recently, compiling with SASS 1.79, some color functions now output deprecation warnings.
This PR keeps the legacy behavior as documented at e.g., https://sass-lang.com/documentation/modules/color/#darken.