Skip to content

test: move serial_tests to nextest test groups #10392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .config/nextest.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[test-groups]
chisel-serial = { max-threads = 1 }

[profile.default]
retries = { backoff = "exponential", count = 2, delay = "3s", jitter = true }
slow-timeout = { period = "1m", terminate-after = 3 }
Expand All @@ -9,3 +12,7 @@ slow-timeout = { period = "5m", terminate-after = 4 }
[[profile.default.overrides]]
filter = "package(foundry-cheatcodes-spec)"
retries = 0

[[profile.default.overrides]]
filter = "package(chisel)"
test-group = "chisel-serial"
26 changes: 0 additions & 26 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/chisel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ walkdir.workspace = true
tikv-jemallocator = { workspace = true, optional = true }

[dev-dependencies]
serial_test = "3"
tracing-subscriber.workspace = true

[features]
Expand Down
10 changes: 0 additions & 10 deletions crates/chisel/tests/cache.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
use chisel::session::ChiselSession;
use foundry_compilers::artifacts::EvmVersion;
use foundry_config::Config;
use serial_test::serial;
use std::path::Path;

#[test]
#[serial]
fn test_cache_directory() {
// Get the cache dir
// Should be ~/.foundry/cache/chisel
Expand All @@ -17,7 +15,6 @@ fn test_cache_directory() {
}

#[test]
#[serial]
fn test_create_cache_directory() {
// Get the cache dir
let cache_dir = ChiselSession::cache_dir().unwrap();
Expand All @@ -30,7 +27,6 @@ fn test_create_cache_directory() {
}

#[test]
#[serial]
fn test_write_session() {
// Create the cache directory if it doesn't exist
let cache_dir = ChiselSession::cache_dir().unwrap();
Expand Down Expand Up @@ -58,7 +54,6 @@ fn test_write_session() {
}

#[test]
#[serial]
fn test_write_session_with_name() {
// Create the cache directory if it doesn't exist
let cache_dir = ChiselSession::cache_dir().unwrap();
Expand All @@ -83,7 +78,6 @@ fn test_write_session_with_name() {
}

#[test]
#[serial]
fn test_clear_cache() {
// Create a session to validate clearing a non-empty cache directory
let cache_dir = ChiselSession::cache_dir().unwrap();
Expand All @@ -108,7 +102,6 @@ fn test_clear_cache() {
}

#[test]
#[serial]
fn test_list_sessions() {
// Create and clear the cache directory
ChiselSession::create_cache_dir().unwrap();
Expand All @@ -135,7 +128,6 @@ fn test_list_sessions() {
}

#[test]
#[serial]
fn test_load_cache() {
// Create and clear the cache directory
ChiselSession::create_cache_dir().unwrap();
Expand Down Expand Up @@ -163,7 +155,6 @@ fn test_load_cache() {
}

#[test]
#[serial]
fn test_write_same_session_multiple_times() {
// Create and clear the cache directory
ChiselSession::create_cache_dir().unwrap();
Expand All @@ -186,7 +177,6 @@ fn test_write_same_session_multiple_times() {
}

#[test]
#[serial]
fn test_load_latest_cache() {
// Create and clear the cache directory
ChiselSession::create_cache_dir().unwrap();
Expand Down
Loading