Add tests precollection logic #3922
Open
+106
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
commented
Nov 6, 2025
|
|
||
| impl TestTarget<TestCandidate> { | ||
| #[tracing::instrument(skip_all, level = "debug")] | ||
| pub fn from_raw(test_target_raw: TestTargetRaw) -> Result<TestTarget<TestCandidate>> { |
Contributor
Author
There was a problem hiding this comment.
note: It's the same as from_raw_deprecated but:
- we don't compile sierra to CASM
- we don't perform config run
This was referenced Nov 12, 2025
franciszekjob
commented
Nov 12, 2025
Comment on lines
+281
to
+284
| pub struct TestCandidate { | ||
| pub name: String, | ||
| pub test_details: TestDetails, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
note: We can easily add partition field which will be later used while filtering.
franciszekjob
requested review from
MKowalski8 and
ksew1
and removed request for
a team
|
Hi! This pull request hasn't had any activity for a while, so I am |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3901
Stack:
OverallSummary->WorkspaceSummary#3918WorkspaceDirs#3917testfunction #3915Introduced changes
Checklist
CHANGELOG.md