Remove --argent option
#4012
Draft
Remove --argent option
#4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKowalski8
requested review from
franciszekjob and
ksew1
and removed request for
a team
This was referenced Dec 10, 2025
cptartur
reviewed
Dec 11, 2025
| json!({ | ||
| "version": 1, | ||
| "variant": { | ||
| // TODO(#3556): Remove hardcoded "argent" and use format! with `AccountType::Ready` |
Member
There was a problem hiding this comment.
What about preexisting argent accounts, I assume the logic to use them is still existing?
Member
Author
There was a problem hiding this comment.
Yes my bad. I didn't think about that
franciszekjob
requested changes
Dec 11, 2025
Contributor
franciszekjob
left a comment
franciszekjob
left a comment
There was a problem hiding this comment.
This breaks backwards compatibility - accounts with type: "argent" should still be recognized and allowed to use.
MKowalski8
force-pushed
the
3678-bump-minimal-scarb
branch
3 times, most recently
from
8ba1491 to
211ae6a
Compare
MKowalski8
changed the base branch from
3678-bump-minimal-scarb
to
3679-panic-backtrace-required
MKowalski8
force-pushed
the
remove-argent
branch
from
c575e49 to
872f9aa
Compare
MKowalski8
force-pushed
the
3679-panic-backtrace-required
branch
from
dfe2e84 to
35b0da6
Compare
MKowalski8
force-pushed
the
remove-argent
branch
from
872f9aa to
72c910e
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
<!-- Reference any GitHub issues resolved by this PR --> Closes #3678 Stack: #4009 #4010 #4011 #4012 ## Introduced changes <!-- A brief description of the changes --> - Bump minimal recommended scarb to `2.12.2` ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
<!-- Reference any GitHub issues resolved by this PR --> Closes #3560 Stack: #4009 #4010 #4011 #4012 ## Introduced changes <!-- A brief description of the changes --> - Remove completion alias ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
MKowalski8
force-pushed
the
3679-panic-backtrace-required
branch
from
35b0da6 to
3316d2b
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
<!-- Reference any GitHub issues resolved by this PR --> Closes #3679 Stack: #4009 #4010 #4011 #4012 ## Introduced changes <!-- A brief description of the changes --> - Add panic-backtrace as required in check_profile function for backtrace ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
MKowalski8
force-pushed
the
remove-argent
branch
from
72c910e to
3ccbb5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3556
Stack:
#4009
#4010
#4011
#4012
Introduced changes
Checklist
CHANGELOG.md