Allow saving network in snfoundry.toml
#4019
Open
+180
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rknet-foundry into allow-using-url-from-config-when-using-account-create-or-import
franciszekjob
requested review from
MKowalski8 and
ksew1
and removed request for
a team
…thub.com/foundry-rs/starknet-foundry into allow-network-in-config
…thub.com/foundry-rs/starknet-foundry into allow-network-in-config
cptartur
requested changes
Dec 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
…t` (#4013) <!-- Reference any GitHub issues resolved by this PR --> **Stack** - #4020 - #4019 - #4017 - #4013 ⬅ Closes # ## Introduced changes When using e.g. `account create` without explicitly passing `--url` or `--network` and having `url` defined in `snfoundry.toml`, we should use the one from config. This PR fixes that. ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
<!-- Reference any GitHub issues resolved by this PR --> **Stack** - #4020 - #4019 - #4017 ⬅ - #4013 Closes # ## Introduced changes <!-- A brief description of the changes --> - ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [ ] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md`
Base automatically changed from
use-url-instead-of-string-in-cast-config
to
master
December 19, 2025 16:31
… into allow-network-in-config
…rs/starknet-foundry into allow-network-in-config
… into allow-network-in-config
MKowalski8
reviewed
Dec 23, 2025
MKowalski8
approved these changes
Dec 23, 2025
cptartur
reviewed
Dec 23, 2025
Comment on lines
+92
to
+98
| pub fn validate(&self) -> anyhow::Result<()> { | ||
| match (&self.url, &self.network) { | ||
| (Some(_), Some(_)) => { | ||
| anyhow::bail!("Only one of `url` or `network` may be specified") | ||
| } | ||
| _ => Ok(()), | ||
| } |
Member
There was a problem hiding this comment.
Maybe let's add an todo for your issue somewhere in code? #4027
| } else { | ||
| unreachable!( | ||
| "`--url` or `--network` must be provided or url must be set in snfoundry.toml" | ||
| "`--url` or `--network` must be provided or url or network fields must be set in snfoundry.toml" |
Member
There was a problem hiding this comment.
Suggested change
| "`--url` or `--network` must be provided or url or network fields must be set in snfoundry.toml" | |
| "`--url` or `--network` must be provided or one of url or network field must be set in snfoundry.toml" |
|
|
||
| #[derive(ValueEnum, Clone, Copy, Debug, PartialEq)] | ||
| #[derive(ValueEnum, Clone, Copy, Debug, PartialEq, Serialize, Deserialize)] | ||
| #[serde(rename_all = "lowercase")] |
Member
There was a problem hiding this comment.
Why do we need this change now?
Comment on lines
+47
to
+48
| url = "http://some.url" | ||
| network = "sepolia" |
Member
There was a problem hiding this comment.
Is having both correct? The validation we have for configs says it shouldn't be.
| account: account_name.into(), | ||
| accounts_file: accounts_file.into(), | ||
| keystore, | ||
| keystore: keystore.map(std::convert::Into::into), |
Comment on lines
+190
to
+194
| let (url, network) = if rpc_args.url.is_some() || rpc_args.network.is_some() { | ||
| (rpc_args.url.clone(), rpc_args.network) | ||
| } else { | ||
| (config.url.clone(), config.network) | ||
| }; |
Member
There was a problem hiding this comment.
Is the case where network is in config and url in rpc_args and vice versa not possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
--add-profileflag #4020networkin snfoundry.toml #4019 ⬅url::Urlinstead of string across sncast #4017urlfrom config foraccount createandaccount import#4013Closes #3250
Introduced changes
Checklist
CHANGELOG.md