Stop passing events to Promise.reject #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image.onerror is passed an event, not an error: getsentry/sentry-javascript#2546 (comment) https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement
Author
|
@fpapado I notice that there has not been an update for three years. Have you given up on this project? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image.onerror is passed an event, not an error:
getsentry/sentry-javascript#2546 (comment)
https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement
Passing reject directly to onerror causes the event to be thrown instead of an error:
getsentry/sentry-javascript#2546