Skip to content

Interpret needs_gpu string as a boolean #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jul 14, 2025

closes #2695

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jul 14, 2025 that may be closed by this pull request
Copy link

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.6 1.33 0.0 0.0
power 0.8 0.6 1.33 0.0 0.0
dataset 0.8 0.6 1.33 0.0 0.0
project 0.8 0.6 1.33 0.0 0.0
job 0.8 0.6 1.33 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.7 8.1 1.07 0.2 0.2
power 193.4 178.0 1.09 89.5 89.5
dataset 91.2 78.9 1.16 4.6 4.6
project 21.0 15.0 1.40 5.8 5.8
job 7.7 7.1 1.08 0.2 0.2

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.0 4.9 1.02 2.2 2.2
power 42.6 39.0 1.09 665.7 665.7
dataset 43.3 43.4 1.00 900.0 900.0
project 18.2 15.4 1.18 282.2 282.2
job 13.3 13.1 1.02 223.6 223.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 6.0 0.98 0.1 0.1
power 5.8 6.2 0.94 0.1 0.1
dataset 5.9 6.4 0.92 0.1 0.1
project 7.4 9.3 0.80 2.3 2.3
job 6.2 6.2 1.00 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.9 4.8 1.02 0.8 0.8
power 4.7 4.5 1.04 0.8 0.8
dataset 5.1 4.8 1.06 0.8 0.8
project 4.9 4.4 1.11 0.8 0.8
job 5.0 4.5 1.11 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 6.5 0.95 1.7 1.7
power 6.1 6.4 0.95 1.7 1.7
dataset 6.3 6.3 1.00 1.7 1.7
project 6.0 6.3 0.95 1.7 1.7
job 6.0 6.5 0.92 1.7 1.7

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.3 9.7 0.96 0.8 0.8
power 12.5 11.6 1.08 28.0 28.0
dataset 10.5 10.4 1.01 16.2 16.2
project 12.1 12.6 0.96 20.4 20.4
job 9.2 8.9 1.03 0.8 0.8

POST /api/v2/project/3/dataset/410/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 28.1 28.2 1.00 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.4 4.0 1.10 0.2 0.2
power 3.9 3.9 1.00 0.2 0.2
dataset 3.7 3.9 0.95 0.2 0.2
project 3.6 3.9 0.92 0.2 0.2
job 3.6 3.9 0.92 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.3 271.3 1.01 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  string_tools.py
  fractal_server/app/runner/executors/slurm_common
  get_slurm_config.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpret needs_gpu string as a boolean
1 participant