Feat/ODBC Browser, History Table ODBC, New Parameter Table#2063
Feat/ODBC Browser, History Table ODBC, New Parameter Table#2063MatthewReed303 wants to merge 2 commits intofrangoteam:masterfrom
Conversation
|
500,000 LOC on this PR. Wow (ridiculous IMO no matter the added functionality) but that's just me. |
|
Nice work on this feature — it’s a pretty big addition 👍 As a first pass, I’d fix a couple of high-level things before we go deeper: 1. Build artifactsPlease remove the generated build files from the PR. 2. Security (ODBC / DB access)Since this introduces quite a bit of database and ODBC logic, we should double-check the security side — especially how queries are handled on the server. Where possible, we should prefer parameterized queries instead of building SQL strings dynamically. For example: const query = `SELECT * FROM users WHERE id = ${userId}`;would be safer as: const query = `SELECT * FROM users WHERE id = ?`;
const result = await connection.query(query, [userId]);This way the driver handles escaping and we reduce injection risks. 3. ODBC device accessThe API lets the client choose the storage type and ODBC device. We should make sure this follows the same authorization pattern used in similar endpoints — i.e. enforce the check when authorization is configured, just like we do elsewhere. Once this is clarified/adjusted, we can go through the implementation in more detail. |
|
@unocelli have done all the above and fixed Angular v18 issues and merge conflict issues |
|
@MatthewReed303 Great, Please remove dist folder from PR. |
9c283b4 to
81fd8a1
Compare
81fd8a1 to
2d14a0f
Compare
|
@unocelli sorry removed them with commit but not from the commit history, all done now |
@concept10 this was due to build files included, all cleaned up now |
ODBC Browser and Enhanced Table Features
This PR introduces comprehensive ODBC database integration and enhanced table functionality to FUXA SCADA.
Key Features Added:
ODBC Browser
Database Integration
New Parameter Table Type
Table Enhancements
Technical Changes: