Skip to content

fix(playbooks): Support wkhtmltox arm64 architecture #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

ceefour
Copy link
Contributor

@ceefour ceefour commented Oct 3, 2020

For Ubuntu 20.04 LTS and later

What type of a PR is this?

  • Bug Fix

Please provide enough information so that others can review your pull request:

Support wkhtmltox arm64 architecture, which is supported starting 0.12.6.

Additionally, it's recommended to update to 0.12.6 for all architectures: frappe/easy_install#24


Explain the details for making this change. What existing problem does the pull request solve? The following checklist could help

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally prior to submission?
  • Have you successfully run tests with your changes locally?
  • Does your commit message have an explanation for your changes and why you'd like us to include them?

To support environments such as AWS Graviton1 & Graviton2.

Screenshots/GIFs

@ceefour ceefour changed the title fix(playbooks): Support wkhtmltopdf arm64 architecture fix(playbooks): Support wkhtmltox arm64 architecture Oct 3, 2020
@ceefour ceefour force-pushed the patch-2 branch 2 times, most recently from 048f64a to 23f2d69 Compare October 3, 2020 08:04
Copy link
Collaborator

@gavindsouza gavindsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ceefour Please address my concerns on the linked Issue so that we can understand the necessity of this fix and get it merged.

@ceefour
Copy link
Contributor Author

ceefour commented Oct 27, 2020

@gavindsouza replied: frappe/easy_install#24

@gavindsouza gavindsouza merged commit 629b272 into frappe:develop Oct 30, 2020
@ceefour ceefour deleted the patch-2 branch October 30, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants