Do not install NumPy on Windows x86 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
I can see what you're doing here; however, would it make more sense to do this with a [[tool.cibuildwheel.overrides]] that targets Windows x86? That way the configuration that tests NumPy will be enforced by any cibuildwheel usage, rather than just the specific CI configuration.
(I'd tweak this myself, but I'm going to be without access to a laptop until July 8. I have access to an iPad so I can review and approve PRs, but I can't author code easily. I appreciate this is unfortunate timing given the impending release deadline; any assistance you're able to provide landing this would be greatly appreciated)
Author
|
Ok, I've updated the commit. Sure, I can author code, that's fine. Thanks for your quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#9030