Skip to content

Add node monitor diagnostics #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 25, 2025
Merged

Add node monitor diagnostics #1681

merged 14 commits into from
Jun 25, 2025

Conversation

netsirius
Copy link
Collaborator

This pull request introduces several changes across multiple files to improve diagnostics capabilities, update dependencies, and refactor testing utilities. The most significant updates include the addition of node diagnostics functionality, refactoring of RNG usage in tests, and updates to dependency paths and versions.

Diagnostics Enhancements:

  • Added a new NodeDiagnostics query type to NodeEvent and QueryResult enums to enable detailed diagnostics, including network state, subscriptions, and metrics. (crates/core/src/message.rs, [1] [2] [3]
  • Implemented logic for collecting and responding to node diagnostics queries, including gathering node info, network info, subscriptions, contract states, system metrics, and peer details. (crates/core/src/node/network_bridge/p2p_protoc.rs, crates/core/src/node/network_bridge/p2p_protoc.rsR404-R557)
  • Added a Diagnostics subcommand to the fdev CLI tool to query detailed node diagnostics. (crates/fdev/src/config.rs, [1]; crates/fdev/src/main.rs, [2]

Testing Utilities Refactor:

  • Refactored base_node_test_config and gw_config_from_path functions to use an external RNG parameter instead of relying on a global RNG lock. (apps/freenet-ping/app/tests/common/mod.rs, [1] [2] [3] [4]

Dependency Updates:

  • Updated freenet-stdlib dependency paths to local directories in multiple Cargo.toml files for better modularity and development flow. (Cargo.toml, [1]; apps/freenet-ping/Cargo.toml, [2]; apps/freenet-ping/app/Cargo.toml, [3]
  • Added a new testing feature to freenet-stdlib in the core crate's dependencies. (crates/core/Cargo.toml, crates/core/Cargo.tomlR110)
  • Updated freenet-stdlib version in test contracts for consistency. (tests/test-contract-metering/Cargo.toml, [1]; tests/test-delegate-integration/Cargo.toml, [2]

Miscellaneous:

@netsirius netsirius requested a review from iduartgomez June 24, 2025 22:22
@iduartgomez iduartgomez merged commit 0131b61 into main Jun 25, 2025
6 checks passed
@iduartgomez iduartgomez deleted the add-node-monitor-queries branch June 25, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants