Skip to content

Remove react-tether positioning library #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JanHamara opened this issue May 27, 2022 · 1 comment · Fixed by #378
Closed
3 tasks done

Remove react-tether positioning library #232

JanHamara opened this issue May 27, 2022 · 1 comment · Fixed by #378
Assignees
@dornelasN @martimalek
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request released
Milestone
Wave@2

Comments

@JanHamara
Copy link
Contributor

JanHamara commented May 27, 2022 •
edited by martimalek
Loading

Describe the feature you'd like

Based on RFC #217 - we have decided to replace react-tether positioning engine with react-popper

Describe alternatives you've considered

@floating-ui/react-dom - Discussion also on #217

What changes need to be done

  • Refactor Tooltip component to use react-popper
  • Refactor Datepicker component to use react-popper (possibly reuse Popover component for Datepicker)
  • Remove react-tether dependency from the project
@JanHamara JanHamara added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 27, 2022
@dornelasN dornelasN self-assigned this Jul 26, 2022
@dornelasN dornelasN mentioned this issue Jul 28, 2022
Merged
1 task
@martimalek martimalek added this to the Wave@2 milestone Aug 28, 2023
@martimalek martimalek mentioned this issue Aug 29, 2023
Merged
2 tasks
@martimalek martimalek mentioned this issue Sep 20, 2023
Merged
1 task
@martimalek martimalek self-assigned this Sep 22, 2023
@martimalek martimalek mentioned this issue Sep 22, 2023
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dornelasN dornelasN

@martimalek martimalek

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request released
Milestone
Wave@2
Development

Successfully merging a pull request may close this issue.

refactor: migrate Datepicker to popper positioning engine freenowtech/wave
3 participants
@dornelasN @JanHamara @martimalek