🐛 Fix init command fails to get release#182
Closed
roziscoding wants to merge 1 commit intofrinyvonnick:masterfrom
Closed
🐛 Fix init command fails to get release#182roziscoding wants to merge 1 commit intofrinyvonnick:masterfrom
roziscoding wants to merge 1 commit intofrinyvonnick:masterfrom
Conversation
The `getChangelog` function used to compare `options.release` with `from-package`, but, on the `init` command, that option is undefined. This changes the behaviour so that, if there's no `options.release`, the package version is used instead.
Owner
Author
|
Hm... I don't think it is, no. About the tests, I can try to implement them, but the reproduction scenario, for me, was just trying to use the |
Closed
Owner
|
I close this pull request in favor of #204. Sorry @roziscoding I prefer a different approach to fix this issue but thank you for the proposal 🙏 It actually helps me a lot. |
Author
|
No problem at all, @frinyvonnick ! |
Merged
Owner
|
I just published it in v2.2.0 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getChangelogfunction used to compareoptions.releasewithfrom-package, but, on theinitcommand, that option is undefined.This changes the behaviour so that, if there's no
options.release, the package version is used instead.