Move browser upgrade page #354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook v2.1.3
merge upstream master
merging upstream master
…into facebook-master
* Adopt Contributor Covenant * Add link to Contributor Covenant to docs site
- use ESLint cache - remove useless `watch` option in fork-ts-checker
Add blog post that takes a React developer step-by-step through many features of AWS. Blog post is suitable for a beginner to follow and have a production ready workflow.
When adding typescript to an existing Create React App project you have to have tsconfig.json in the project, I believe this change should clarify it for beginners getting stuck on this step. Not sure if providing an example would be too much so I have added a link to the tsconfig.json instead.
Add a link to React Router docs specific to adding routes.
Remove reference to deprecated VSCode debugger plugin. https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-chrome
fix code splitting link
fix broken link progressive web app
docs: Add Link to Adding Routes Docs
update the heroku buildpack link
Add missing instruction if you are adding typescript
VSCode debugger plugin deprecated
- add modernizr - config modernizr - add in tests and initial banner logic
|
|
rileytb
commented
Aug 12, 2024
| @@ -0,0 +1,7 @@ | |||
| const header = document.getElementById('outdated-browser'); | |||
| const outdatedFeatures = Object.keys(Modernizr).filter(feature => !Modernizr[feature]); | |||
| const unsupportedBrowserFlag = getFeatureFlag('frontier_snow_unsupportedBrowser', {appName: process.env.APP_NAME}); | |||
rileytb
commented
Aug 12, 2024
| "test/dom/intersection-observer", | ||
| "test/es6/promises", | ||
| "test/network/fetch", | ||
| "test/url/parser" |
There was a problem hiding this comment.
Looked at packages/react-scripts/polyfills.js and usage of these across apps to gather this list.
…de-landing-page-to-react
…er-upgrade-landing-page-to-react
This reverts commit 98d0078.
…ge-to-react' of https://github.com/fs-webdev/create-react-app into rileytb/EOLBFRST-253_wd-move-browser-upgrade-landing-page-to-react
rileytb
deleted the
rileytb/EOLBFRST-253_wd-move-browser-upgrade-landing-page-to-react
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an "upgrade your outdated browser" banner that will display with feature detection.
Associated story EOLBFRST-253
Along with that this PR adds in modernizr (feature checking library). There is now a
pre:buildscript which generates themodernizr.jsfile based on themodernizr-config.jsonfile.Modernizr config has in it these options as I saw them giving us coverage for things that we use and keep us from supporting things like IE.