Skip to content

Fixed ID type deserialization #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hth313
Copy link
Contributor

@hth313 hth313 commented Feb 5, 2020

Deserialization of ID types caused an exception if the field was
nullable.

This corrects #244 and adds a test-case for it.

Deserialization of ID types caused an exception if the field was
nullable.
@xperiandri
Copy link
Collaborator

@hth313 is this already fixed? Can we close this PR?

@hth313
Copy link
Contributor Author

hth313 commented Sep 11, 2022

I have no idea. I made a couple of PRs, some were merged but I do not think all of them. Not sure why and it was a long time ago. Looking at it now it seems that this was not merged, the misspelled "sring" is still there, but the actual fix does not match the code anymore. I really have no idea, I moved on, you can do what you feel is best.

@xperiandri
Copy link
Collaborator

As you can see I push this library forward. Soon we will have the latest GraphQL grammar support, CI&CD, solution template, etc.. So if you can check and update your PR I would appreciate that

@hth313
Copy link
Contributor Author

hth313 commented Sep 11, 2022

It is good to see healthy open source projects. Sadly I will most likely not be able to update the PR as I work in very different dev stacks these days. I do not have needed tools and VMs installed for this anymore.

@xperiandri
Copy link
Collaborator

@hth313 add me to you fork repo as editor, please

@xperiandri xperiandri changed the title Deserialization Fixed ID type deserialization Dec 6, 2022
@hth313
Copy link
Contributor Author

hth313 commented Dec 7, 2022

You can just fork, clone or define a remote to it and pull things from it as needed.
The project is here: https://github.com/hth313-forks/FSharp.Data.GraphQL/tree/deserialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants