Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rabernat : a pickleable OpenFile in-a-context looks something like this, see what you think. Now entering
with
returns the OpenFile itself, which is now really file-like. It exists so that a chain of file-likes (compression, text...) can be closed in sequence at the right time. None of this affects what you get when you do afs.open()
, which objects are often pickleable (http, s3, local...), but this is not guaranteed.Note that it breaks a couple of previous pickle tests, I will need to see whether the assumptions there are valid or not. Particularly, what should it mean to unpickle a "w"-mode file - naively, a new file gets opened with mode "w", invalidating the previous copy and truncating the file.