Fix ReferenceFileSystem.cat for unsorted lists of paths #1158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
here's a potential fix for the issue revealed in zarr-developers/zarr-python#1324
I added a test to check the order of returned data when using
FSMap.getitems
Without the fix, it errors with
Regarding the fix: I'm not sure if this should be solved differently, since the non-merging codepath is probably the more common. Also I haven't tested if
DFReferenceFileSystem.cat
has the same issue...Cheers,
Andreas 😃