add in connect_kwargs arg to S3FileSystem for passing boto3 args to the client upon connection #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
force-pushed
the
connect_kwargs
branch
from
dbd8ecf to
72d5f7b
Compare
|
cc @martindurant any thoughts? |
| @@ -166,7 +171,8 @@ def connect(self, refresh=False): | |||
| self.session = boto3.Session(self.key, self.secret, self.token, | |||
| **self.kwargs) | |||
| if tok not in self._conn: | |||
There was a problem hiding this comment.
the token should fold in the connect_kwargs, because a connection to one endpoint is not the same as a connection to another, even if all the credentials are the same.
| @@ -113,12 +114,16 @@ class S3FileSystem(object): | |||
| read_timeout = 15 | |||
|
|
|||
| def __init__(self, anon=False, key=None, secret=None, token=None, | |||
| use_ssl=True, **kwargs): | |||
| use_ssl=True, connect_kwargs=None, **kwargs): | |||
There was a problem hiding this comment.
I would call this client_kwargs to be more specific
…e client upon connection
jreback
force-pushed
the
connect_kwargs
branch
from
8274af5 to
a608044
Compare
|
@martindurant fixed up and now passing. the tokenize was the problem. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.