Skip to content

Fixed false positives when using <slot> with <transition>. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 1 commit into from
Nov 28, 2019
Merged

Fixed false positives when using <slot> with <transition>. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/styles/selectors/query/elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function getWrapperTransition(
if (isTransitionElement(parent) || isTransitionGroupElement(parent)) {
return parent
}
if (!isSkipElement(parent)) {
if (!isSlotElement(parent) && !isSkipElement(parent)) {
return null
}
parent = parent.parent
Expand Down
48 changes: 48 additions & 0 deletions tests/lib/rules/no-unused-selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,54 @@ tester.run("no-unused-selector", rule, {
.foo > div {}
</style>
`,
// transition
`
<template>
<transition>
<div/>
</transition>
</template>
<style scoped>
.v-enter,
.v-enter-active,
.v-enter-to,
.v-leave,
.v-leave-to,
.v-leave-active {}
</style>
`,
`
<template>
<transition name="foo">
<div/>
</transition>
</template>
<style scoped>
.foo-enter,
.foo-enter-active,
.foo-enter-to,
.foo-leave,
.foo-leave-to,
.foo-leave-active {}
</style>
`,
`
<template>
<!-- transition + slot -->
<transition name="foo">
<slot />
</transition>
</template>
<style scoped>
.foo-enter,
.foo-enter-active,
.foo-enter-to,
.foo-leave,
.foo-leave-to,
.foo-leave-active {}
</style>
`,

// options
// ignoreBEMModifier
{
Expand Down
47 changes: 47 additions & 0 deletions tests/lib/rules/require-selector-used-inside.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,53 @@ tester.run("require-selector-used-inside", rule, {
:not(.a) {}
</style>
`,
// transition
`
<template>
<transition>
<div/>
</transition>
</template>
<style scoped>
.v-enter,
.v-enter-active,
.v-enter-to,
.v-leave,
.v-leave-to,
.v-leave-active {}
</style>
`,
`
<template>
<transition name="foo">
<div/>
</transition>
</template>
<style scoped>
.foo-enter,
.foo-enter-active,
.foo-enter-to,
.foo-leave,
.foo-leave-to,
.foo-leave-active {}
</style>
`,
`
<template>
<!-- transition + slot -->
<transition name="foo">
<slot />
</transition>
</template>
<style scoped>
.foo-enter,
.foo-enter-active,
.foo-enter-to,
.foo-leave,
.foo-leave-to,
.foo-leave-active {}
</style>
`,
// options
// ignoreBEMModifier
{
Expand Down