test(notebooklm): benchmarks + unit tests for notebooks/sources/queries (refs #305)#568
Open
test(notebooklm): benchmarks + unit tests for notebooks/sources/queries (refs #305)#568
Conversation
…spec Closes #519 - Add gf16_zero(), gf16_from_u32(), gf16_to_u32() to specs/numeric/gf16.t27 - Add EmitResult, emit_rust_stmt(), emit_rust() to specs/compiler/meta_compile.t27 - 9 tests + 6 invariants across both specs - Verified: tri test compiler::meta_compile PASSED, tri test compiler::numeric/gf16 PASSED PHI LOOP: edit spec → seal hash → gen → test → verdict → save experience → skill commit → git commit
- Restore bridge.rs from c539af3 (40+ unresolved merge conflicts) - Add Cyrillic docs to legacy allowlist - Fix duplicate if-branch in compiler.rs (Dot -> ColonColon) - Create gen/c/numeric/gf4.c stub - Exclude ffi crate from workspace (broken C codegen)
…lparam Fixes test_roundtrip_uart_spec regression. The lexer emits :: as a single ColonColon token but the use-statement parser expected two separate Colon tokens, causing all const declarations after use statements to be skipped. Also enhances HirVerilogEmitter to emit constants with values as localparam instead of bare wire. 524 passed 1 failed -> 525 passed 0 failed
… trigger scope (Closes #332)
…refs #305) - test_benchmarks.py: 5 benchmarks — client creation, wrapup format, error code comparison, constant access, token lifecycle - test_notebooks.py: Notebook creation, find_by_name, serialization - test_sources.py: MAX_SOURCE_SIZE, upload/list/delete without client - test_queries.py: query without client, empty query handling All 8 test files pass (27+ tests total)
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
qmtech_a100t.xdc had 23 invalid pins from FGG484/FGG676 packages. Fixed: rst_n C18->C17, SPI G8/G7/G5->G4/G3/G2, mac_result[0] D6->D7, removed mac_result[8:31] (insufficient valid CSG324 pads). Added scripts/fpga/jtag_bitbang.py for Xilinx Platform Cable USB II programming via pyusb bitbang JTAG (ready when xusb_xp2.hex available). conformance/clara_spec_coverage.json: 36/36 PASS.
…ntation - VSA ternary bind/unbind/bundle operations on FPGA (DIM=10000) - Parameterized Verilog modules with 10/10 testbench pass - Matches canonical spec: specs/vsa/vsa_core.t27 - Pushed to gHashTag/trinity-fpga under fpga/vsa/
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9844729 | Triggered | Generic Password | 9d47e26 | external/opencode/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends NotebookLM test coverage for issue #305 acceptance criteria:
New test files
test_benchmarks.py— 5 performance benchmarks matching spec bench blocks:test_notebooks.py— Notebook creation, find_by_name, serialization (3 tests)test_sources.py— MAX_SOURCE_SIZE, upload/list/delete without client (4 tests)test_queries.py— Query without client, empty query handling (2 tests)Test results
Refs #305
Test plan
python3 contrib/backend/notebooklm/tests/run_tests.py— 5/5 pass