Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Switch leader election to leases#119

Merged
timebertt merged 1 commit intogardener-attic:masterfrom
timebertt:enh/leader-election-leases
Apr 15, 2021
Merged

Switch leader election to leases#119
timebertt merged 1 commit intogardener-attic:masterfrom
timebertt:enh/leader-election-leases

Conversation

@timebertt
Copy link
Copy Markdown
Contributor

@timebertt timebertt commented Apr 13, 2021 •
edited
Loading

How to categorize this PR?

/area scalability
/kind enhancement

What this PR does / why we need it:

Switch leader election to leases.

configmapsleases has been the default since g/grm@v0.22.0 (used in g/g since v1.18.0), so I think it's safe to migrate to leases in g/grm@v0.24.0, even without any special migration logic.

Which issue(s) this PR fixes:
Fixes #77

Special notes for your reviewer:

Release note:

The default leader election resource lock of `gardener-resource-manager` has been changed from `configmapsleases` to `leases`.
Please make sure, that you had at least `gardener-resource-manager@v0.22` running before upgrading to `v0.24`, so that it has successfully required leadership with the hybrid resource lock (`configmapsleases`) at least once.

@timebertt timebertt requested a review from a team as a code owner April 13, 2021 14:10
@gardener-robot gardener-robot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2021
@gardener-attic gardener-attic deleted a comment from gardener-robot Apr 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 13, 2021
rfranzke
rfranzke approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 13, 2021
@timebertt timebertt merged commit c9a4936 into gardener-attic:master Apr 15, 2021
@timebertt timebertt deleted the enh/leader-election-leases branch April 15, 2021 06:01
@timebertt timebertt mentioned this pull request Apr 28, 2021
Merged
@dependabot dependabot bot mentioned this pull request May 6, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rfranzke rfranzke rfranzke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch leader election to lease

4 participants

@timebertt @rfranzke @gardener-robot-ci-2 @gardener-robot