Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Allow to configure leader election settings#72

Merged
ialidzhikov merged 1 commit intogardener-attic:masterfrom
rfranzke:feature/leader-election-settings
Aug 5, 2020
Merged

Allow to configure leader election settings#72
ialidzhikov merged 1 commit intogardener-attic:masterfrom
rfranzke:feature/leader-election-settings

Conversation

@rfranzke
Copy link
Copy Markdown
Contributor

@rfranzke rfranzke commented Aug 5, 2020

How to categorize this PR?

/area robustness cost networking
/kind enhancement
/priority normal

What this PR does / why we need it:
With this PR we allow to configure the leader election settings for the gardener-resource-manager to allow users to configure them as appropriate for their use-cases.

Which issue(s) this PR fixes:
Part of gardener/gardener#1953

Special notes for your reviewer:
/invite @timebertt @vlerenc

Release note:

It is now possible to specify the leader election settings via the following command line parameters: `--leader-election-lease-duration` (default: `15s`), `--leader-election-renew-deadline` (default: `10s`), `--leader-election-retry-period` (default: `2s`).

@rfranzke rfranzke requested a review from a team as a code owner August 5, 2020 08:23
@gardener-robot gardener-robot added area/cost Cost related area/networking Networking related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review priority/normal labels Aug 5, 2020
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 5, 2020
@rfranzke
Copy link
Copy Markdown
Contributor Author

rfranzke commented Aug 5, 2020

/invite @zanetworker @wyb1 @istvanballok

Copy link
Copy Markdown
Contributor

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 5, 2020
@ialidzhikov ialidzhikov merged commit 07ebe64 into gardener-attic:master Aug 5, 2020
@rfranzke rfranzke deleted the feature/leader-election-settings branch August 5, 2020 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cost Cost related area/networking Networking related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants