Repository navigation
docs(garnet): keep the release-testing label off demo pull requests - #47
Conversation
The gate posts its ten-leg verdict on every labelled pull request. A pull request written to be shared or offered upstream needs its conversation clear for the reader, so the label stays off it and the same commits get gated through a second, labelled pull request from the same branch. Recorded in the ledger rules and in the agent guide.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Execution Profiles recorded for 1 job, triggered by
|
|
/agentic_review |
|
@coderabbitai review |
Jibril release gate ·
|
| leg | result |
|---|---|
| L1 startup | PASS — sensor active, status ok, github steps resolution ok |
| L2 profile | uploaded after 0s · 01a084d4-5433-7115-a2b5-34efcb30aa86 · 4 egress peers, 3 destinations |
| L3 workload | destination present, but attributed to steps ["0. Start the clock"] instead of "Workload with egress" |
| L4 App comment | final after 1s · #47 (comment) |
| L5 permalink | html 200 · api 200 · https://app.garnet.ai/public/runs/34318659037?profile=01a084d4-5433-7115-a2b5-34efcb30aa86 |
| L6 integration shape | action 3d47f4a9; sensor version left to the action; explicit token |
| L7 integration run | TS CI run 34318651427 finished success with no profile (no profile is bound to that run): the job was green, the sensor recorded nothing |
| L8 reviewers | zizmor: no workflow files touched · unresolved bot threads on .github/: 0 |
| L9 timing | sensor start 14s · workload 1s with sensor vs 1s without · overhead 14s (budget 120s) · profile visible 0s after the job · comment final 1s after the profile |
| L10 coverage | 1 of 6 CI cells instrumented: ubuntu/node 24 · not instrumented: ubuntu/node 22, ubuntu/node 26, windows 1/3/node 22, windows 2/3/node 22, windows 3/3/node 22 · Linux x86_64 only; macOS, Windows, fork PRs and Dependabot runs record nothing |
| record | value |
|---|---|
| jibril | requested v2.17.0-rc.10 · resolved v2.17.0-rc.10 |
| action | garnet-org/action@e546567a72e4fede11ec39d6e9f75b539adef22c |
| run | 34318659037 attempt 1 · blacksmith-01m22cmhqemvsx8m34y8qeqbag-8vcpu · pull_request |
| workflow ref seen by sensor | garnet-labs/pnpm/.github/workflows/garnet-jibril-release-gate.yml@refs/pull/47/merge |
| base → head | 16aa2a8 → 5e81767 |
| merge sha at run | eafe967 · now eafe967 · profile recorded eafe967 (refs/pull/47/merge) |
| comparison in comment | no previous (first record on this PR) |
| synthetic merge | yes · sensor recorded merge commit eafe967, PR head is 5e81767 |
Failing legs:
- L3 workload: destination present, but attributed to steps ["0. Start the clock"] instead of "Workload with egress"
- L7 integration run: TS CI run 34318651427 finished success with no profile (no profile is bound to that run): the job was green, the sensor recorded nothing
Disclosed, not failing:
- L6 shape: release.yml keeps 2 Garnet step(s) on macOS jobs; the sensor never records there (CodeRabbit and Qodo flagged this on fork PRs)
- L6 shape: ci.yml passes the token explicitly, so Dependabot-actor runs get an empty value and record nothing (upstream pull 13270)
Legs map to past failures in .github/garnet-gate/FAILURE_LEDGER.md. Full record in the run's garnet-release-gate artifact.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
|
Code review by qodo was updated up to the latest commit 5e81767 |
PR Summary by QodoClarify Garnet release-testing labels for demo pull requests
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
PR Code Suggestions ✨Warning
No code suggestions found for the PR. |
| To gate the same commits, open a second pull request from the same | ||
| branch and label that one. |
There was a problem hiding this comment.
When the demo pull request is already open from this branch to its base, GitHub rejects another pull request with that identical head/base pair. The documented procedure therefore cannot create the required labelled gate pull request, leaving the acceptance path unusable. Create a separate gate branch at the same commit, then open and label that pull request; update the matching instruction in AGENTS.md as well.
Artifacts
- The authored Bash script performs a GET for an open pull request and then submits an identical head/base POST request, showing the duplicate is rejected.
- The live GitHub GET response identifies open PR 46 and records its same-repository head branch and `main` base before the duplicate request.
- The live GitHub Create Pull Request response returned HTTP 422 with the message that a pull request already exists for the selected head branch, proving the written procedure is not viable.
- The command execution log records the proof script, repository working directory, successful expected-rejection assertion, and exit code 0.
Summary
The Jibril release gate runs on the
garnet-release-testinglabel and posts a ten-leg verdict comment on the pull request. That is right for test pull requests (pin bumps, release candidates, gate work, acceptance runs) and wrong for a pull request written to be shared, presented, or offered upstream, where the reader should see the change, the Runtime Review comment, and the pull request's own evidence.This records the distinction in two places agents read before labelling:
.github/garnet-gate/FAILURE_LEDGER.md, rule 2: test pull requests carry the label; demo pull requests never do; to gate the same commits, open a second pull request from the same branch and label that one.AGENTS.md, new section "Garnet pull requests on this fork": the same two kinds, which workflow the label starts, and the note that removing the label does not remove a verdict the gate already posted.No workflow change. The gate itself is unchanged.
Squash Commit Body
Checklist
Written by an agent (Devin).
Link to Devin session: https://app.devin.ai/sessions/0a9b03641469419c9060f560ca6b7e85
Open in Devin Desktop: https://app.devin.ai/desktop/session/0a9b03641469419c9060f560ca6b7e85?variant=devin
Requested by: @jadoonf
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Runtime evidence (Garnet)
Kernel-recorded execution record for head
5e817672e12ba8ad23f1ae6689bb97038d783479, mirrored verbatim fromthe sticky Garnet Runtime Review comment on this PR so reviewers that read only
the description ground in the same bytes. Facts only. Judgment stays with the
reviewer. Cite grounded findings as:
Execution record (verbatim mirror)
Execution Profiles recorded for 1 job, triggered by
5e81767Garnet Jibril Release Gate/reproduce↗ · 3 destinationsRunner.Worker └─ bash └─ curl (step: "Start the clock") ├─ ○ localhost (dns resolver) └─ ○ registry.npmjs[.]org systemd └─ systemd-resolved └─ ○ 8.8.8.8View this job's Execution Profile in Garnet →
💡 How to read this
Runner.Worker ← process on a path └─ npm └─ node ← process that acted └─ ○ npmjs[.]org ← observed actionfollow a path downward to see what ran and what it did — each path to an observed action is an execution chain
names on the path = processes · ○ = observed action · (…) = context
Workload behaviour (Garnet)
Garnet Jibril Release Gate/reproduce· headeafe967· 5 workload chains · 2 runner-platform chainsWorkload behaviour vs
ba67148: +0 −8 destinations−
github[.]com−
codeload.github[.]com−
nodejs[.]org−
node-registry.bit[.]cloud−
pnpm[.]io−
release-assets.githubusercontent[.]com−
unofficial-builds.nodejs[.]org−
npm.jsr[.]iorunner platform: +0 −19 destinations · not workload behaviour
5 workload chains · 2 destinations at head, 8 gone
localhostcurl,node,sudoregistry.npmjs[.]orgcurl,nodecodeload.github[.]comnodegithub[.]comgit-remote-http,nodenode-registry.bit[.]cloudnodenodejs[.]orgnodenpm.jsr[.]ionodepnpm[.]ionoderelease-assets.githubusercontent[.]comnodeunofficial-builds.nodejs[.]orgnoderunner platform · 2 chains · 2 destinations at head, 19 gone · no recorded workflow step
8.8.8.8systemd-resolvedlocalhostsudo140.82.112.22nginx140.82.113.21nginx140.82.114.21nginx169.254.169.123chronyd185.125.190.56chronyd185.125.190.57chronyd185.125.190.58chronyd192.168.127.1blacksmithd,sudo198.137.202.56chronyd23.143.196.204chronyd23.186.168.128chronyd5.161.94.12chronyd91.189.91.157chronydapi.snapcraft[.]iosnapdcloudfront.cdn.snapcraftcontent[.]comsnapdnodejs[.]orgpnpmproductionresultssa15.blob.core[.]windowsnoderegistry.npmjs[.]orgpnpmunofficial-builds.nodejs[.]orgpnpmrecorded at the kernel by Garnet · profile view →
Greptile Summary
Summary
AGENTS.mdmust be updated as well.Confidence Score: 3/5
Not safe to merge until the documented gate-pull-request procedure can be followed successfully.
A live request confirmed that GitHub rejects a second open pull request using the same head branch and base branch, so the required acceptance workflow is currently unusable.
Files Needing Attention: .github/garnet-gate/FAILURE_LEDGER.md and AGENTS.md
What T-Rex did
Comments Outside Diff (1)
General comment
FAILURE_LEDGER.md:21-22andAGENTS.md:357instruct users to open a second pull request from the same branch to gate the same commits. GitHub rejected a live Create Pull Request request using an already-open PR's exact head branch and base branch with HTTP 422.Reviews (1): Last reviewed commit: "docs(garnet): keep the release-testing l..." | Re-trigger Greptile