Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Execution Profiles recorded for 1 job, triggered by
|
|
|
||
| - name: Install pinned pnpm | ||
| shell: bash | ||
| run: npm install --global "pnpm@$PNPM_VERSION" |
|
/agentic_review |
|
@coderabbitai review |
Code Review by Qodo
1. PR scripts mint job identity
|
|
|
||
| permissions: | ||
| contents: read | ||
| id-token: write |
There was a problem hiding this comment.
1. Pr scripts mint job identity 🐞 Bug ⛨ Security
Static inference: the workflow grants id-token: write to the same job that checks out and executes PR-controlled lifecycle scripts. A same-repository PR can replace either fixture script, request the job's OIDC token, and authenticate to any external service whose trust policy accepts this workflow identity.
Agent Prompt
## Issue description
The pull-request workload executes repository-controlled lifecycle scripts in a job that can request an OIDC identity token.
## Fix Focus Areas
- .github/workflows/garnet-git-prepare-skip-builds-replay.yml[10-12]
- .github/workflows/garnet-git-prepare-skip-builds-replay.yml[109-118]
## Recommended Fix
Remove `id-token: write` from this job because the Garnet action already receives its API token explicitly. If OIDC is mandatory, execute the PR-controlled install in an isolated environment that does not receive the runner's OIDC request URL or bearer token.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Summary
Fork-only diagnostic specimen, not for merge.
Adds a two-cell Garnet replay for a nested git/prepare install. A local git fixture has one unapproved transitive lifecycle build, while the outer project allowlists only the git root package. The strict cell makes ignored builds fatal; the nonfatal cell skips the same build and lets the install complete.
The step summary records both exit codes, the ignored-build diagnostic, whether the git root prepare ran, whether the transitive install ran, and the temporary prepare checkout path. Both cells use pnpm 12.3.4. The only A/B variable is
pnpm_config_strict_dep_builds, inherited by the nested install.Squash Commit Body
Checklist
Written by an agent (Cursor, GPT-5.6 Sol).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Runtime evidence (Garnet)
Kernel-recorded execution record for head
68235e6eab82183538488104fdad31d51e2687bf, mirrored verbatim fromthe sticky Garnet Runtime Review comment on this PR so reviewers that read only
the description ground in the same bytes. Facts only. Judgment stays with the
reviewer. Cite grounded findings as:
Execution record (verbatim mirror)
Execution Profiles recorded for 1 job, triggered by
68235e6Garnet git prepare skipped-builds replay/replay↗ · 4 destinationsRunner.Worker ├─ bash │ └─ pnpm (step: "<unknown>") │ └─ ○ registry.npmjs[.]org └─ ○ localhost (dns resolver) systemd ├─ hosted-compute-agent │ └─ sudo │ └─ provjobd (ran from /tmp/…) │ └─ ○ 140.82.112.23 └─ python3.12 └─ python3.12 └─ ○ 168.63.129.16View this job's Execution Profile in Garnet →
💡 How to read this
Runner.Worker ← process on a path └─ npm └─ node ← process that acted └─ ○ npmjs[.]org ← observed actionfollow a path downward to see what ran and what it did — each path to an observed action is an execution chain
names on the path = processes · ○ = observed action · (…) = context
Workload behaviour (Garnet)
Garnet git prepare skipped-builds replay/replay· head4accd5e· 7 workload chains · 4 runner-platform chainsWorkload behaviour vs
ba67148: +0 −8 destinations−
github[.]com−
codeload.github[.]com−
nodejs[.]org−
node-registry.bit[.]cloud−
pnpm[.]io−
release-assets.githubusercontent[.]com−
unofficial-builds.nodejs[.]org−
npm.jsr[.]iorunner platform: +2 −20 destinations · not workload behaviour
7 workload chains · 2 destinations at head, 8 gone
registry.npmjs[.]orgpnpmlocalhostpnpmcodeload.github[.]comnodegithub[.]comgit-remote-http,nodenode-registry.bit[.]cloudnodenodejs[.]orgnodenpm.jsr[.]ionodepnpm[.]ionoderelease-assets.githubusercontent[.]comnodeunofficial-builds.nodejs[.]orgnoderunner platform · 4 chains · 3 destinations at head, 20 gone · no recorded workflow step
168.63.129.16python3.12,systemd-resolved140.82.112.23provjobd811922291localhostRunner.Worker140.82.112.22nginx140.82.113.21nginx140.82.114.21nginx169.254.169.123chronyd185.125.190.56chronyd185.125.190.57chronyd185.125.190.58chronyd192.168.127.1blacksmithd,sudo198.137.202.56chronyd23.143.196.204chronyd23.186.168.128chronyd5.161.94.12chronyd8.8.8.8nginx,systemd-resolve91.189.91.157chronydapi.snapcraft[.]iosnapdcloudfront.cdn.snapcraftcontent[.]comsnapdnodejs[.]orgpnpmproductionresultssa15.blob.core[.]windowsnoderegistry.npmjs[.]orgpnpmunofficial-builds.nodejs[.]orgpnpmrecorded at the kernel by Garnet · profile view →