Open
Conversation
Pull Request Test Coverage Report for Build 3131333191
💛 - Coveralls |
Collaborator
Author
|
@kevin-bates I would appreciate second pair of eyes to look at it. |
kevin-bates
approved these changes
Dec 7, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Hi Dimitry, this is really slick. I just had a couple of comments. Since I don't use the CLI, I'm not up on how this all comes into play. The changes look good and I trust you've checked things out - so I'm happy to approve this to move things forward. I'll leave the addressing of the comments up to you.
(Please note I'm on vacation through the end of the year, so my responses will be spotty. Thank you for all the work you do on this project!)
| description='Client for Hadoop® YARN API') | ||
|
|
||
| parser.add_argument('--endpoint', help='API endpoint (https://test.cluster.com:8090)') | ||
| #parser.add_argument('--api_class', help='Please provide api class - rm, hs, nm, am', required=True) |
Member
There was a problem hiding this comment.
Is this intentionally commented out? If so, perhaps an additional comment as to why or when it should be uncommented would be helpful.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #104
As there's just way too many methods to describe, I chose the least effortful approach to have maximum coverage.
New logic is going to pull the entire list of all available arguments in each of methods of each implemented class and generate dynamic argparsers on the fly, this way reducing headache of support in the future.
If any new method gets added, it can be included in the listing in main.py. If any method gets a different set of arguments, new logic will automatically use that.
Majority of devops engineers already know what all these arguments mean, and in terms of automation it will do just fine...
What is still pending: