Repository navigation
fix(gatsby-source-mongodb): sanitize name correctly - #11294
Merged
Merged
Conversation
DSchau
changed the title
DSchau
previously requested changes
Jan 25, 2019
DSchau
left a comment
DSchau
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments. Thanks so much for the PR!
Contributor
Author
|
@DSchau thank you so much for the feedback! Working on it. |
Contributor
Author
|
@DSchau may you please review the changes? Thank You. |
pieh
reviewed
Jan 30, 2019
wardpeet
added
the
status: awaiting author response
Contributor
|
@harshil1712 can you merge then fix the conflict in Thanks so much! |
Contributor
Author
|
@DSchau I tried the steps. Please review it 😄 |
DSchau
reviewed
Feb 7, 2019
DSchau
reviewed
Feb 7, 2019
Contributor
Author
|
@DSchau the lodash library is being used. Please refer line 76 and 77 |
As suggested, since lodash is not being used, it is not required Co-Authored-By: harshil1712 <ghagrawal17@gmail.com>
Contributor
Author
|
@DSchau I have made the changes as you suggested. Please review it. Thank you. |
wardpeet
added
status: awaiting reviewer response
wardpeet
removed
the
status: awaiting reviewer response
wardpeet
approved these changes
Mar 12, 2019
wardpeet
left a comment
wardpeet
left a comment
Contributor
There was a problem hiding this comment.
Updated and merged with master! Ready to merge!
|
Holy buckets, @harshil1712 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
This was referenced Sep 16, 2021
Open
This was referenced Dec 1, 2021
This was referenced Jun 24, 2023
This was referenced Nov 28, 2023
This was referenced Jan 5, 2024
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
<!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description This is the PR for issue gatsbyjs#11277. It fixes the sanitizeName error. <!-- Write a brief description of the changes introduced by this PR --> ## Related Issues Related to gatsbyjs#11277 <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc. --> Co-authored-by: Dustin Schau <DSchau@users.noreply.github.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the PR for issue #11277. It fixes the sanitizeName error.
Related Issues
Related to #11277