Skip to content

fix(gatsby-image): check if imageRef is still available #22255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatsbybot merged 4 commits into from
Mar 20, 2020
Merged

fix(gatsby-image): check if imageRef is still available #22255

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c96b7b9
fix(gatsby-image): check if imageRef is still available
wardpeet Mar 13, 2020
a508a72
Update index.js
wardpeet Mar 16, 2020
70cbbd0
Merge branch 'master' into fix/gatsby-image-null
wardpeet Mar 20, 2020
bc64d60
Merge remote-tracking branch 'upstream/master' into fix/gatsby-image-…
Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/gatsby-image/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,11 @@ class Image extends React.Component {
imgLoaded: imageInCache,
// `currentSrc` should be a string, but can be `undefined` in IE,
// !! operator validates the value is not undefined/null/""
imgCached: !!this.imageRef.current.currentSrc,
// for lazyloaded components this might be null
// TODO fix imgCached behaviour as it's now false when it's lazyloaded
imgCached: !!(
this.imageRef.current && this.imageRef.current.currentSrc
),
})
)
})
Expand Down