fix(docs): change bash to shell in code language blocks#22899
Merged
LekoArts merged 9 commits intogatsbyjs:masterfrom Jun 22, 2020
Merged
fix(docs): change bash to shell in code language blocks#22899LekoArts merged 9 commits intogatsbyjs:masterfrom
LekoArts merged 9 commits intogatsbyjs:masterfrom
Conversation
LekoArts
previously requested changes
Apr 15, 2020
Contributor
Author
|
good catch. in line 209 it says it is in both: gatsby/packages/gatsby-remark-prismjs/README.md Lines 209 to 210 in 2a7cb8c maybe (in a new PR) would be good to add the gatsby/packages/gatsby-remark-prismjs/src/index.js Lines 91 to 96 in 2f0044d - [`bash`].includes(languageName) &&
+ [`bash`,`shell`].includes(languageName) && |
MichaelDeBoey
previously approved these changes
Apr 18, 2020
MichaelDeBoey
previously approved these changes
Apr 19, 2020
Ekwuno
previously approved these changes
Apr 20, 2020
Contributor
Ekwuno
left a comment
Ekwuno
left a comment
There was a problem hiding this comment.
Removed "$" from the shell commands
MichaelDeBoey
suggested changes
Apr 20, 2020
MichaelDeBoey
suggested changes
Apr 20, 2020
Contributor
Author
|
i think all requested changes are solved... |
MichaelDeBoey
previously approved these changes
Apr 29, 2020
muescha
dismissed
LekoArts’s stale review
fixed in: #23256 fix(gatsby-remark-prismjs): Update useCommandLine
# Conflicts: # docs/blog/2018-04-04-gatsby-contentful-starter-tutorial/index.md # docs/blog/2020-01-08-git-workflows/index.md
muescha
force-pushed
the
muescha/fix/docs-bash-to-shell
branch
from
896ffed to
488a0cb
Compare
Contributor
Author
|
merged from master |
Contributor
Author
|
🎉 |
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Lennart <lekoarts@gmail.com> Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changed:
bashtoshellregarding the code style guides to prefershellRelated links