fix: wrap ignore pattern in quotes#23176
Merged
blainekasten merged 1 commit intogatsbyjs:masterfrom Apr 16, 2020
Merged
Conversation
madalynrose
reviewed
Apr 16, 2020
Contributor
madalynrose
left a comment
madalynrose
left a comment
There was a problem hiding this comment.
Wow thanks for going through and hunting down all of these! Are there any tests we can add around this to catch anything added in the future?
blainekasten
approved these changes
Apr 16, 2020
Contributor
|
I'm going to merge this as is. The downsides of this are relatively little so I am okay with skipping tests on it. |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So I've been seeing a reoccurring issue with the Gatsby monorepo on my local Windows (WSL) dev environment. When I ran
yarn bootstrapthebabelcli created files atpackages/gatsby-source-graphql/batching/__tests__even though__tests__should be ignored.The issue was
zsh(my shell) and it already appeared in this previous PR: #14465So I'm adding this to every script so that people don't accidentally commit files that should be ignored / not be generated via Babel. In the past I always had to exclude/delete those files first which is annoying and you can easily forget it.
Related Issues
#14465