Skip to content

fix: move babel/types from devDependencies to dependencies #26404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Aug 12, 2020

Description

Moved @babel/types from devDependencies to dependencies (added in #25401)

The e2e test didn't catch this since the portal protocol installs devDependencies

Related Issues

Fixes https://github.com/yarnpkg/berry/runs/972966147#step:5:146

@merceyz merceyz requested a review from a team as a code owner August 12, 2020 12:03
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 12, 2020
@freiksenet freiksenet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 12, 2020
@merceyz
Copy link
Contributor Author

merceyz commented Aug 25, 2020

@wardpeet Sorry to ping you and bump this PR but its been failing our CI for two weeks now

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! for pinging me. Looks good!

@wardpeet wardpeet merged commit 318a8a2 into gatsbyjs:master Aug 25, 2020
@merceyz merceyz deleted the merceyz/babel-types branch August 25, 2020 10:29
@wardpeet
Copy link
Contributor

Successfully published:

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants