Skip to content

feat: upgrade to remark 13#29678

Merged
vladar merged 35 commits into
masterfrom
v3/remark-upgrade
Apr 9, 2021
Merged

feat: upgrade to remark 13#29678
vladar merged 35 commits into
masterfrom
v3/remark-upgrade

Conversation

@vladar
Copy link
Copy Markdown
Contributor

@vladar vladar commented Feb 22, 2021

Description

Upgraded remark-related packages. Listed all known dom tree changes in the discussion: #30385

BREAKING CHANGES:

Plugin deps updated:

  • ✅ gatsby-transformer-remark
  • ✅ gatsby-remark-autolink-headers
  • ✅ gatsby-remark-code-repls
  • ✅ gatsby-remark-copy-linked-files
  • ⛔ gatsby-remark-custom-blocks (blocked by remark@next (13) zestedesavoir/zmarkdown#416)
  • ✅ gatsby-remark-embed-snippet
  • ✅ gatsby-remark-graphviz
  • ✅ gatsby-remark-images
  • ✅ gatsby-remark-images-contentful
  • ✅ gatsby-remark-katex
  • ✅ gatsby-remark-prismjs
  • ✅ gatsby-remark-responsive-iframe
  • ✅ gatsby-remark-smartypants

List of remark plugins compatible with v13:
https://github.com/remarkjs/remark/blob/main/doc/plugins.md#list-of-plugins

Discussion

See umbrella discussion #30385

@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@vladar vladar added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 22, 2021
Comment on lines +634 to +636
<li>
<p><a href=\\"/my%20little%20pony/#third-title\\">third title</a></p>
</li>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-13.0 change (happens even with 12.0) Makes sense to me because now top-level list items have consistent markup (expand above to compare with the item having a sub-list)

@vladar vladar changed the title chore(gatsby-transformer-remark): ugprade remark-related deps chore: ugprade remark-related deps Feb 22, 2021
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
* chore(gatsby-transformer-remark): ugprade remark-related deps

* tests: update snapshots for ToC

* enable remark-gfm in a backwards compatible way

* gatsby-remark-autolink-headers: bump deps

* gatsby-remark-code-repls: bump deps

* gatsby-remark-copy-linked-files: bump deps

* gatsby-remark-prismjs: bump deps

* gatsby-remark-prismjs: fix breaks

* gatsby-remark-embed-snippet: bump deps and fix breaks

* gatsby-remark-graphviz: bump deps

* gatsby-remark-images: bump deps

* gatsby-remark-images-contentful: bump deps

* gatsby-remark-katex: bump deps

* gatsby-remark-responsive-iframe: bump deps

* gatsby-remark-smartypants: bump deps

* update yarn.lock

* gatsby-remark-prismjs: update snapshots

* gatsby-remark-images-contentful: bump deps

* chore: bump root remark deps

* gatsby-remark-katex: update snapshot

* gatsby-remark-responsive-iframe: update snapshot

* gatsby-remark-autolink-headers: update snapshot

* gatsby-remark-autolink-headers: update snapshot

* gatsby-remark-autolink-headers: fix tests

* gatsby-remark-code-repls: update snapshot

* gatsby-remark-smartypants: update snapshot

* gatsby-remark-custom-blocks: disable plugin tests

There is no version of `remark-custom-blocks` that is compatible with remark v13 yet. See zestedesavoir/zmarkdown#416

* dummy commit for canary

* run prettier and update yarn.lock

* gatsby-transformer-remark: update unified and unist-utils

* gatsby-remark-autolink-headers: correct text in tests

* gatsby-remark-custom-blocks: incompatibility notice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: remark/mdx Related to Markdown, remark & MDX ecosystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants