Skip to content

Conversation

@cometkim
Copy link
Contributor

@cometkim cometkim commented Jun 3, 2021

Description

In latest version of react/react-dom@experimental, there is no unstable_ prefix for createRoot

Related Issues

See facebook/react#21488

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's move everything to the new syntax and remove unstable_createRoot. Also can you update the message that they have to use at least that version

@cometkim
Copy link
Contributor Author

cometkim commented Jun 3, 2021

Yep found it. It's https://www.npmjs.com/package/react/v/0.0.0-experimental-2bf4805e4 published 22 days ago.

@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 4, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wardpeet wardpeet merged commit 087cdd5 into gatsbyjs:master Jun 4, 2021
@cometkim cometkim deleted the react-experimental branch June 6, 2021 10:47
vladar pushed a commit that referenced this pull request Jun 8, 2021
vladar pushed a commit that referenced this pull request Jun 8, 2021
…om (#31750) (#31829)

(cherry picked from commit 087cdd5)

Co-authored-by: Hyeseong Kim <[email protected]>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants