fix(gatsby): assign correct parentSpans to PQR activities#33568
Merged
Conversation
gatsbot
Bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
commented
Oct 18, 2021
|
|
||
| const cacheActivity = report.activityTimer(`Caching Webpack compilations`, { | ||
| parentSpan: buildActivityTimer.span, | ||
| parentSpan: buildSpan, |
Contributor
Author
There was a problem hiding this comment.
buildActivityTimer (activity for browser bundling) would finish before it, so that parentSpan was incorrect
wardpeet
pushed a commit
that referenced
this pull request
Oct 18, 2021
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
This was referenced Jan 25, 2022
This was referenced Feb 19, 2022
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is fixing couple of activities (notably PQR related) that weren't setting
parentSpancorrectly and traces were not correct because of it