fix(gatsby): Sanitize length on objects#34253
Merged
LekoArts merged 7 commits intogatsbyjs:masterfrom Nov 24, 2022
Merged
Conversation
gatsbot
bot
added
the
status: triage needed
iChenLei
commented
Dec 14, 2021
| path.add(data) | ||
|
|
||
| const returnData = isPlainObject ? {} : [] | ||
| // Refer to https://github.com/gatsbyjs/gatsby/issues/26565 |
Contributor
Author
There was a problem hiding this comment.
_.each is work for both arrary and object and show high performance, so that's why gatsbyjs use it at here. For preventing OOM when we use _.each to loop { length: SUPER_MAX_INTEGER, ... } object, we also can refact these code to Object.keys or other implemention. It's depends on the opinion of the gatsby team.
LekoArts
added
topic: remark/mdx
LekoArts
approved these changes
Nov 24, 2022
Contributor
LekoArts
left a comment
LekoArts
left a comment
There was a problem hiding this comment.
Thanks 👍 The file was since then moved to TS so I refactored a bit and added a unit test. Functionality is the same as yours
LekoArts
changed the title
length fieldlength on objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #26565
Documentation
N/A
Related Issues
lodash/lodash#2352