Skip to content

feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly) - #35529

Merged
TylerBarnes merged 11 commits into
masterfrom
feat/wp-use-image-cdn-for-files-in-html
May 4, 2022
Merged

TylerBarnes merged 11 commits into
masterfrom
feat/wp-use-image-cdn-for-files-in-html

Conversation

@TylerBarnes

@TylerBarnes TylerBarnes commented Apr 29, 2022 •

Copy link
Copy Markdown
Contributor

Fixes #35213

@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 29, 2022
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 29, 2022
@TylerBarnes TylerBarnes changed the title feat(gatsby-source-wordpress): use image cdn for files in html feat(gatsby-source-wordpress): use image cdn for non-resizable images in html Apr 29, 2022
return relativeUrl
}

const filterMatches =

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function isn't being used anywhere 🤔 not sure why but it was dead code so I deleted it

@TylerBarnes TylerBarnes changed the title feat(gatsby-source-wordpress): use image cdn for non-resizable images in html feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly) Apr 30, 2022
@TylerBarnes
TylerBarnes marked this pull request as ready for review April 30, 2022 01:52
@TylerBarnes

Copy link
Copy Markdown
Contributor Author

Hmm, tests are failing 🤔 I'll fix

@LekoArts LekoArts added topic: source-wordpress Related to Gatsby's integration with WordPress topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) labels May 3, 2022
wardpeet
wardpeet previously approved these changes May 4, 2022
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
… in html (svgs/gifs mainly) (gatsbyjs#35529)

* use image cdn from non-resizeable image types in html image tags

* start adding svg test

* remove dead code and update comments

* move try/catch one level higher and add needed info to publicUrlResolver

* add untransformable image in html unit test

* add svg image integration test

* fix test after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-wordpress Related to Gatsby's integration with WordPress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gatsy 4.10.1 - Gatsby-soure-wp 6.10.0 inline svg's are not given static url yet are rendered with source urls

3 participants