Skip to content

fix(graphiql-explorer): Adjust env var truthiness logic - #37032

Merged
tyhopp merged 2 commits into
masterfrom
fix-graphiql-env-var-truthiness
Nov 14, 2022
Merged

tyhopp merged 2 commits into
masterfrom
fix-graphiql-env-var-truthiness

Conversation

@tyhopp

@tyhopp tyhopp commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Description

Allow refresh endpoint in GraphiQL explorer to be enabled with ENABLE_GATSBY_REFRESH_ENDPOINT=true, currently only works with ENABLE_GATSBY_REFRESH_ENDPOINT=1 due to the unary plus.

Briefly tried adding gatsby-core-utils as a dep to use the isTruthy util, but that didn't work for some reason so I added a limited version of the logic instead.

Documentation

Related Issues

Fixes #37002

@tyhopp tyhopp added the topic: GraphQL Related to Gatsby's GraphQL layer label Nov 14, 2022
@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2022
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2022
@tyhopp
tyhopp merged commit 19dd1c4 into master Nov 14, 2022
@tyhopp
tyhopp deleted the fix-graphiql-env-var-truthiness branch November 14, 2022 07:23
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
* fix(graphiql-explorer): Adjust env var truthiness logic

* Fix lint for declaration in case block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: GraphQL Related to Gatsby's GraphQL layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gatsby v5 graphiql missing ENABLE_GATSBY_REFRESH_ENDPOINT feature.

2 participants