fix(gatsby-source-wordpress): allow using engines when using wordpress auth#38103
Merged
fix(gatsby-source-wordpress): allow using engines when using wordpress auth#38103
Conversation
…s auth Co-authored-by: Lennart <lekoarts@gmail.com>
gatsbot
Bot
added
the
status: triage needed
pieh
added
topic: source-wordpress
pieh
commented
May 22, 2023
| import type { Step } from "./../utils/run-steps" | ||
| import type { IPluginOptions } from "~/models/gatsby-api" | ||
|
|
||
| let storedAuthSettings: IPluginOptions["auth"] | undefined |
Contributor
Author
There was a problem hiding this comment.
not greatest to store as module variable, but I lack context on this plugin internals, so if there is a better way - happy to adjust
Contributor
There was a problem hiding this comment.
I think this is ok. The plugins internals aren't great 😜 wish I could undo the way it manages state so this is preferrable imo.
pieh
commented
May 22, 2023
Comment on lines
+17
to
+21
| exports.onPreBootstrap = runApiSteps( | ||
| [steps.restoreAuthPluginOptions], | ||
| `onPreBootstrap` | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this runs after we write out browser plugin options and before bundling engines, so good spot to do restoration
TylerBarnes
approved these changes
May 24, 2023
Contributor
Author
|
Published in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#32303 removes
options.authfrom plugin options to prevent leaking them to browser. However this later causes problems for engines as they are missing auth information.This PR keeps removal of auth, but it restores it later after browser plugin options is written out. Above PR added tests to ensure secrets are not leaked, so we should be still guarded against that
Documentation
Tests
Related Issues