Skip to content

Fix inlined styles with path-prefixing #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Fix inlined styles with path-prefixing #4717

merged 1 commit into from
Mar 26, 2018

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Mar 26, 2018

No description provided.

@ghost ghost assigned jquense Mar 26, 2018
@ghost ghost added the review label Mar 26, 2018
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fix!

})
})
).filter(s => isString(s))
const scripts = scriptsAndStyles.filter(s => s.endsWith(`.js`))
const styles = scriptsAndStyles.filter(s => s.endsWith(`.css`))

const runtimeRaw = fs.readFileSync(
`${process.cwd()}/public/${runtimeScript}`,
join(process.cwd(), `public`, runtimeScript),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, you'd think I'd remember to do this by now :-(

@KyleAMathews KyleAMathews merged commit 09f9d9e into v2 Mar 26, 2018
@ghost ghost removed the review label Mar 26, 2018
@KyleAMathews KyleAMathews deleted the fix-static-styles branch March 26, 2018 17:16
@m-allanson m-allanson mentioned this pull request Mar 27, 2018
m-allanson added a commit to m-allanson/gatsby that referenced this pull request Apr 4, 2018
* v2:
  Docgen improvements (gatsbyjs#4757)
  adjust createLocation calls after gatsbyjs#4714 (gatsbyjs#4805)
  Update breaking changes doc
  use basename for router instead of prefixing in link (gatsbyjs#4714)
  Fix inlined styles with path-prefixing (gatsbyjs#4717)
  Publish
  Upgrade & format
  [v2][wip] Upgrade Gatsby v2 to webpack 4 (gatsbyjs#4588)
  fix some jsdoc parsing bits (gatsbyjs#4675)
  [v2] fix wrong merge
  Publish
  Migrate to React Hot Loader v4 (gatsbyjs#4500)
  [v2] Fix deleteNodes deprecation (gatsbyjs#4453)
  Publish
  Switch to latest version of sharp to prevent yarn/npm errors (gatsbyjs#4417)

# Conflicts:
#	packages/gatsby/package.json
#	packages/gatsby/src/utils/webpack-utils.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants