Fix onRouteUpdate & onPreRouteUpdate #7142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for using-postcss-sass failed. Built with commit 2181e53 https://app.netlify.com/sites/using-postcss-sass/deploys/5b6acebf67610c2209cd8f8c |
|
Deploy preview for using-drupal ready! Built with commit 2181e53 |
|
Deploy preview for gatsbygram ready! Built with commit 2181e53 |
m-allanson
reviewed
Aug 8, 2018
| @@ -47,11 +46,9 @@ globalHistory.listen(() => { | |||
| apiRunner(`onPreRouteUpdate`, { location }) | |||
| } | |||
| // Make sure React has had a chance to flush to DOM first. | |||
|
Deploy preview for gatsbyjs failed. Built with commit bd194aa https://app.netlify.com/sites/gatsbyjs/deploys/5b6ac7e7e39e7c1bf9c35f25 |
|
Deploy preview for gatsbyjs failed. Built with commit 2181e53 https://app.netlify.com/sites/gatsbyjs/deploys/5b6acebe67610c2209cd8f80 |
m-allanson
added a commit
that referenced
this pull request
Aug 8, 2018
* master: (21 commits) Disable www-graphql-docker-push.sh (#7127) chore(release): Publish Fix onRouteUpdate & onPreRouteUpdate (#7142) chore(release): Publish Fix showing dev 404 page when there isn't one in development (#7140) Replace 'serve' package w/ express-static to restore compression (#7139) Fix tests (#7138) Add delay to cyress test where cyress kept failing chore(release): Publish (#6581): v2 docs building apps with gatsby overview update (#7115) Added my blog to sites (#7125) Add babel-plugin-macros (#7129) Update babel.md (#7012) (#6590): flesh out preparing your environment overview stub (#7137) [gatsby-plugin-netlify] update static cache header to match docs (#7132) (#7118): Clarify prettier instructions and update tutorial sidebar (#7130) Fixing spelling error (#7136) chore(release): Publish Try publishing again chore(release): Publish ... # Conflicts: # yarn.lock
m-allanson
added a commit
that referenced
this pull request
Aug 8, 2018
* master: (566 commits) chore(release): Publish Fix mistakenly identifying files as using commonjs when they weren't (#7153) Update collectPackages to getPackages for new lerna rc (#7126) Update index.md (#7145) Disable www-graphql-docker-push.sh (#7127) chore(release): Publish Fix onRouteUpdate & onPreRouteUpdate (#7142) chore(release): Publish Fix showing dev 404 page when there isn't one in development (#7140) Replace 'serve' package w/ express-static to restore compression (#7139) Fix tests (#7138) Add delay to cyress test where cyress kept failing chore(release): Publish (#6581): v2 docs building apps with gatsby overview update (#7115) Added my blog to sites (#7125) Add babel-plugin-macros (#7129) Update babel.md (#7012) (#6590): flesh out preparing your environment overview stub (#7137) [gatsby-plugin-netlify] update static cache header to match docs (#7132) (#7118): Clarify prettier instructions and update tutorial sidebar (#7130) ... # Conflicts: # yarn.lock
porfirioribeiro
pushed a commit
to porfirioribeiro/gatsby
that referenced
this pull request
Aug 22, 2018
* Fix onRouteUpdate * Apply same treatment to onPreRouteUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the initial onRouteUpdate actually run after the route has been rendered (previously wasn't)
Also should be more reliable than the previous setTimeout thing as we're using
React's
componentDidUpdatelifecycle hook which I believe also ensuresonce React async hits that it's run after all children have finished rendering.
Fixes #7142