Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added
the
MBARI-LRAUV
Author
|
@chapulina PTAL! |
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 99.72% 99.73%
=======================================
Files 67 68 +1
Lines 6219 6314 +95
=======================================
+ Hits 6202 6297 +95
Misses 17 17
Continue to review full report at Codecov.
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
suggested changes
Mar 22, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
add-polynomial3-class
branch
from
79d493c to
4d8d4b1
Compare
chapulina
approved these changes
Mar 23, 2022
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Thanks for iterating, LGTM!
ahcorde
pushed a commit
that referenced
this pull request
Jul 4, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
chapulina
added a commit
that referenced
this pull request
Jul 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Split from #387. This PR introduces a Polynomial3 class to cubic polynomials with real coefficients.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.