Skip to content

Make ignstrtok private to Utility.cc#107

Merged
chapulina merged 1 commit intogazebosim:ign-msgs6from
mahiuchun:static
Dec 4, 2020
Merged

Make ignstrtok private to Utility.cc#107
chapulina merged 1 commit intogazebosim:ign-msgs6from
mahiuchun:static

Conversation

@mahiuchun
Copy link
Contributor

Signed-off-by: Hill Ma hillma@google.com

Otherwise we might get ODR issue with ign-common/src/Util.cc

Signed-off-by: Hill Ma <hillma@google.com>
@mahiuchun mahiuchun requested a review from caguero as a code owner December 4, 2020 08:25
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 4, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@chapulina chapulina merged commit 187e175 into gazebosim:ign-msgs6 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔮 dome Ignition Dome 🏢 edifice Ignition Edifice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants