Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 84.59% 84.78% +0.18%
==========================================
Files 7 7
Lines 818 828 +10
==========================================
+ Hits 692 702 +10
Misses 126 126
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jan 25, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Not really sure If you should target main or ign-msgs7
main is correct, adding fields breaks ABI.
LGTM, let's just make sure all fields are documented before merging.
| Header header = 1; | ||
|
|
||
| double radius = 2; | ||
| double length = 3; |
Contributor
There was a problem hiding this comment.
Can you document all fields? (We're doing this for new messages / fields)
| /// \brief Optional header data | ||
| Header header = 1; | ||
|
|
||
| Vector3d radii = 2; |
Signed-off-by: ahcorde <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added capsule and ellipsoid msgs.
Not really sure If you should target
mainorign-msgs7Signed-off-by: ahcorde ahcorde@gmail.com