Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Feb 4, 2021
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 7 7
Lines 828 828
=======================================
Hits 702 702
Misses 126 126 Continue to review full report at Codecov.
|
chapulina
reviewed
Feb 4, 2021
proto/ignition/msgs/light.proto
Outdated
| float spot_inner_angle = 13; | ||
| float spot_outer_angle = 14; | ||
| float spot_falloff = 15; | ||
| float intensity = 18; |
Contributor
There was a problem hiding this comment.
Can we put it in order below? Also, please document all new fields.
Signed-off-by: ahcorde <ahcorde@gmail.com>
iche033
approved these changes
Feb 4, 2021
iche033
reviewed
Feb 4, 2021
| uint32 parent_id = 17; | ||
|
|
||
| /// \brief light intensity | ||
| float intensity = 18; |
Contributor
There was a problem hiding this comment.
can we default this to 1.0?
Contributor
Author
There was a problem hiding this comment.
Explicit default values are not allowed in proto3.
Contributor
Author
There was a problem hiding this comment.
maybe we can force this as a required field
Contributor
There was a problem hiding this comment.
ok I see, lets leave it as is then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added light intensity field to light.proto. Related with this issue gazebosim/gz-rendering#232
Signed-off-by: ahcorde ahcorde@gmail.com