Support 'has' functionality in particle Emitter.#137
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-msgs6 #137 +/- ##
==========================================
Coverage 84.59% 84.59%
==========================================
Files 7 7
Lines 818 818
==========================================
Hits 692 692
Misses 126 126 Continue to review full report at Codecov.
|
chapulina
left a comment
There was a problem hiding this comment.
This breaks API and can't go into a stable release. It needs to be retargeted to main, and even then, I think we should consider a tick-tock strategy.
The particle emitter was added in the last minor release. I'm making this change in a subsequent minor release. The impact is minimal and is needed by subt. |
|
Ok, let's make this exception since there are probably no users of particles yet and the release is still fresh. In the future, we should consider making pre-releases for new features that are still under development. We need to time well the next Can you add a note about the ABI break to the migration guide? |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Added in ef3e3f4 |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig nate@openrobotics.org
🦟 Bug fix
Summary
The particle emitter message used plain data types. This prevents an Ignition system from knowing if a value has been set. Since we are using the emitter message as the
Componentin Ignition, we need this information.I'm changing the message types. Since this message was just introduced the impact should be minimal.
Required by: gazebosim/gz-sim#651
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge